Opened 8 years ago

Closed 8 years ago

#13813 closed enhancement (fixed)

AMD: dojo/data/*

Reported by: Chris Mitchell Owned by: Chris Mitchell
Priority: high Milestone: 1.7
Component: Data Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Port dojo/data/* to AMD (except API's which are docs only)

Change History (3)

comment:1 Changed 8 years ago by Chris Mitchell

Resolution: → fixed
Status: new → closed

In [26440]:

fixes #13813 ported dojo/data stores to AMD with min deps.\!strict

comment:2 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: closed → reopened

ItemFileWriteStore currently has a runtime error, as return ItemFileWriteStore; references a variable that doesn't exist. Perhaps you intended to add var ItemFileWriteStore = ... in front of the declare?

Also I notice ObjectStore simply shoves a return in front of the declare whereas IFRS stores it in a variable and returns that. I am not sure which is considered "correct" in baseless conversions, but it should probably be made consistent...

(Thanks to cole_gillespie on IRC for alerting me to the IFWS breakage.)

comment:3 Changed 8 years ago by Chris Mitchell

Resolution: → fixed
Status: reopened → closed

In [26445]:

fixes #13813 fix ItemFileWriteStore? amd conversion probs \!strict

Note: See TracTickets for help on using tickets.