Opened 8 years ago

Closed 8 years ago

#13806 closed defect (patchwelcome)

Shrinksafe stripConsole missing methods

Reported by: PhillipStallworthy Owned by: Richard Backhouse
Priority: low Milestone: tbd
Component: ShrinkSafe Version: 1.7.0b1
Keywords: shrinksafe needsreview Cc:
Blocked By: Blocking:

Description

Shrinksafe has a nice stripConsole option that removes the firebug console.* logging methods from your code, however it misses 5 current ones: console.clear(), exception, firebug, groupCollapsed and table.

I have attached a patch to fix this including a test update.

build.sh - changed equality test to work in my dash shell, and other sh shells. runner.sh - changed to work with current AMD modules

I have filed a CLA.

Attachments (2)

shrinksafe_stripConsole.txt (4.2 KB) - added by PhillipStallworthy 8 years ago.
shrinksafe_stripConsole.patch (4.2 KB) - added by PhillipStallworthy 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by PhillipStallworthy

Attachment: shrinksafe_stripConsole.txt added

Changed 8 years ago by PhillipStallworthy

comment:1 Changed 8 years ago by PhillipStallworthy

Extension of patch amended to .patch so it opens in browser nicely, but couldn't delete .txt version

comment:2 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:3 Changed 8 years ago by bill

Resolution: patchwelcome
Status: newclosed

I think closure will be the compressor of choice going forwards, and we don't have anyone working on shrinksafe, so closing this ticket.

Note: See TracTickets for help on using tickets.