Opened 8 years ago

Closed 8 years ago

#13787 closed enhancement (fixed)

Consider Provide "moveFrom" in TransitionIn events

Reported by: Ming Zhe Huang Owned by: ykami
Priority: high Milestone: 1.7
Component: DojoX Mobile Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

This actually derives from the work on mobile showcase. In many cases of listening to TransitionIn? events, we need to know where the source view is. It would be better to provide this info in the context of Transition events, like "onAfterTransitionIn" or "/dojox/mobile/afterTransitionIn".
IMHO, the "moveTo" or "toWidget" provided for TransitionIn? events seems less useful, because when we listen to a view on those event, we already know those information.
So another proposal is that replace "moveTo"/"toWidget" with "moveFrom"/"fromWidget".

Change History (3)

comment:1 Changed 8 years ago by ykami

Milestone: tbd1.8

IMHO, the "moveTo" or "toWidget" provided for TransitionIn?? events seems less useful, because when we listen to a view on those event, we already know those information.

Well, actually no, you don't know the information if a hash sign (#) for the bookmarkable feature and/or moveTo parameters are given. (e.g. moveTo="#bar&myParam=0001") If we changed moveTo to moveFrom as you suggested, test_hash-parameter.html would no longer work. Basically, parameters for those listeners are to pass parameters that are given to View#performTransition.

That said, I can understand your requirement. I will consider how we could pass the source view info to the listeners.

comment:2 Changed 8 years ago by ykami

Resolution: fixed
Status: newclosed

In [26596]:

Fixes #13787 !strict Before making a transition, set the starting view id to the movedFrom property of the destination view so that transition event handlers, such as onAfterTransitionIn, can access the starting view.

comment:3 Changed 8 years ago by bill

Milestone: 1.81.7
Note: See TracTickets for help on using tickets.