Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13786 closed defect (fixed)

Icons - Cannot Scroll to Top if Open Box in Scrollable View

Reported by: Ming Zhe Huang Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.0b1
Keywords: Cc: Atsushi Ono
Blocked By: Blocking:

Description

Please see the attached video. Also test case is attached.
This problem is similar with #13777.

  • The open box is inserted as a sibling of mblScrollableViewContainer
  • Moreover, the open box has "position:absolute" which means even if we pull it into mblScrollableViewContainer, it will still cause scroll problem.

Attachments (3)

testIconOpenbox.swf​ (126.5 KB) - added by Ming Zhe Huang 8 years ago.
video
test_icon-openbox.html​ (1.6 KB) - added by Ming Zhe Huang 8 years ago.
test case
13786.patch​ (4.1 KB) - added by Atsushi Ono 8 years ago.
[patch][ccla] patch to fix the issue by not using native scrollIntoView()

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Ming Zhe Huang

Attachment: testIconOpenbox.swf​ added

video

Changed 8 years ago by Ming Zhe Huang

Attachment: test_icon-openbox.html​ added

test case

comment:1 Changed 8 years ago by ykami

Cc: Atsushi Ono added

comment:2 Changed 8 years ago by ykami

Confirmed the problem. Thank you for finding this.

Changed 8 years ago by Atsushi Ono

Attachment: 13786.patch​ added

[patch][ccla] patch to fix the issue by not using native scrollIntoView()

comment:3 Changed 8 years ago by Atsushi Ono

This issue is caused by calling native scrollIntoView() inside scrollable. I have attached a patch to fix the issue as follows:

  • Add a new scrollable#scrollIntoView(node) function, which adjusts scrollable's scroll position to scroll the specified node into the scrollable's displaying area.
  • Use the new function above when IconItem is placed inside scrollable, otherwise use window.scrollBy instead of native scrollIntoView because it sometimes fails on some Android devices.

comment:4 Changed 8 years ago by ykami

Resolution: → fixed
Status: new → closed

In [27715]:

Fixes #13786 !strict Added scrollIntoView() equivalent for ScrollableView?. Thank you onoat for the patch.

comment:5 Changed 8 years ago by bill

Milestone: tbd → 1.8

No milestone specified, bulk update to 1.8.

Note: See TracTickets for help on using tickets.