lazy loading of dojo/dnd/Source via require results in uncaught exception

[Adam Peller]

Uncaught TypeError: Cannot read property 'Source' of undefined from AutoSource.js, line 3

the shim in Source.js loads compatibility code in a dojo.ready. If Source.js is loaded after page load, this executes immediately, resulting in a circular dependency. AutoSource extends Source, and Source hasn't finished loading yet. Is it as simple as putting the shim after the declare?

[Adam Peller]

test case was invalid. the typo 'dojox' instead of 'dojo' caused the error. Still trying to find a case where the dojo.ready fires immediately.

[Adam Peller]

ok, I think I got a real test case this time.

[bill]

test case

[bill]

Rawld, what do you think?

The problem only occurs when calling dojo.require() through eval().

But when using eval(), the require() call in dojo/dnd/Source.js executes immediately even though we are clearly in the middle of loading a module (and hence, not ready).

BTW, test case goes in dojo/tests/dnd

[bill]

Problem is now also occurring in dojox/mobile/tests/test_iPhone-IconMulti.html, after clicking the "Calendar" button (to show the Calendar). Clicking that button calls

dojo["require"](s)

where s == "dijit.form.Calendar", which loads dijit/form/_FormWidget.js, and then the dojo.ready() callback in _FormWidget.js runs immediately, rather than waiting until _FormWidget.js itself has finished loading.

// Back compat w/1.6, remove for 2.0
if(dojo && dojo.ready && !dojo.isAsync){
  dojo.ready(0, function(){
    var requires = ["dijit/form/_FormValueWidget"];
    require(requires); // use indirection so modules not rolled into a build
  });
}

Calendar was changed recently in #13814 but ISTM that change is OK, and merely triggers this problem with the loader.

(Tested on FF5/mac.)

[Rawld Gill]

In [26652]:

hold the idle state when immediately executing modules in legacy sync mode; fixes #13784; !strict

[ykami]

Verified that dijit.Calendar can be loaded and instantiated dynamically. Thank you for fixing this.

[Adam Peller]

...and Maqetta works great with this patch also. Thanks!