Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13775 closed defect (fixed)

[patch] [cla] IE7 gfx invalid argument (negative values)

Reported by: Karl Tiedt Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7.1
Component: DojoX GFX Version: 1.6.1
Keywords: vml ie6 ie7 invalid argument Cc:
Blocked By: Blocking:

Description

In IE < 8, negative height/width values produce an invalid argument error breaking charting/gfx in places where every other browsers work fine... a simple patch to this makes it work (and since VML is IE only... it really is no performance hit)

Attachments (1)

vml.patch​ (987 bytes) - added by Karl Tiedt 8 years ago.
dojx/gfx/vml.js patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Karl Tiedt

Attachment: vml.patch​ added

dojx/gfx/vml.js patch

comment:1 Changed 8 years ago by Karl Tiedt

Forcing Math.max(....., 0) just makes all IE's resolve the invalid values to the same value ultimately... if at all possible I would love to see this make it into the 1.7 since its a tiny patch and low risk.

comment:2 Changed 8 years ago by Patrick Ruzand

Resolution: → fixed
Status: new → closed

In [27012]:

fixes #13775 ensures positive width/height. thx ktiedt (cla)

comment:3 Changed 8 years ago by Patrick Ruzand

In [27013]:

refs #13775 ensures positive width/height. thx ktiedt (cla)

comment:4 Changed 8 years ago by bill

Milestone: tbd → 1.8

comment:5 Changed 8 years ago by Patrick Ruzand

Milestone: 1.8 → 1.7.1
Note: See TracTickets for help on using tickets.