Opened 8 years ago
Closed 8 years ago
#13774 closed defect (wontfix)
DeferredList consumeErrors parameter is ignored
| Reported by: | gualandi | Owned by: | Mark Wubben |
|---|---|---|---|
| Priority: | high | Milestone: | tbd |
| Component: | Core | Version: | 1.6.1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
The consumeErrors parameter of the DeferredList constructor has no effect, and the results of rejected deferreds are passed on even when it is set.
The addResults inner function should use this parameter to filter only successful results before resolving the deferredlist deferred.
Attachments (1)
Change History (7)
comment:1 Changed 8 years ago by
| Component: | General → Core |
|---|---|
| Description: | modified (diff) |
| Owner: | set to Kris Zyp |
Changed 8 years ago by
| Attachment: | consumeOnError.js added |
|---|
comment:3 follow-up: 4 Changed 8 years ago by
I don't understand why this would be the correct behavior, this would make the indexes be out of sync between the provided deferred list and the resulting resolved list.
comment:4 Changed 8 years ago by
Good point. What is the point of this parameter then? I seem to be missing something here.
comment:5 Changed 8 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | changed from Kris Zyp to Mark Wubben |
| Status: | new → assigned |
Mark, do you want to close as wontfix? Promise/all doesn't even have a consumeErrors (aka ignoreErrors) parameter, so presumably it's not something you want to support.
comment:6 Changed 8 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | assigned → closed |
Yea I'll close. promise/all either gives you a failure or all results, different behavior should be in a different helper. DeferredList is effectively deprecated so let's not try and fix anything.
I assume you mean the fourth parameter, consumeErrors? Can you attach a test case?