Opened 8 years ago

Closed 7 years ago

#13774 closed defect (wontfix)

DeferredList consumeErrors parameter is ignored

Reported by: gualandi Owned by: Mark Wubben
Priority: high Milestone: tbd
Component: Core Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

The consumeErrors parameter of the DeferredList constructor has no effect, and the results of rejected deferreds are passed on even when it is set.

The addResults inner function should use this parameter to filter only successful results before resolving the deferredlist deferred.

Attachments (1)

consumeOnError.js (651 bytes) - added by gualandi 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by bill

Component: GeneralCore
Description: modified (diff)
Owner: set to Kris Zyp

I assume you mean the fourth parameter, consumeErrors? Can you attach a test case?

Changed 8 years ago by gualandi

Attachment: consumeOnError.js added

comment:2 Changed 8 years ago by gualandi

Sure, I added a test case.

comment:3 Changed 8 years ago by Kris Zyp

I don't understand why this would be the correct behavior, this would make the indexes be out of sync between the provided deferred list and the resulting resolved list.

comment:4 in reply to:  3 Changed 8 years ago by gualandi

Good point. What is the point of this parameter then? I seem to be missing something here.

comment:5 Changed 7 years ago by bill

Description: modified (diff)
Owner: changed from Kris Zyp to Mark Wubben
Status: newassigned

Mark, do you want to close as wontfix? Promise/all doesn't even have a consumeErrors (aka ignoreErrors) parameter, so presumably it's not something you want to support.

comment:6 Changed 7 years ago by Mark Wubben

Resolution: wontfix
Status: assignedclosed

Yea I'll close. promise/all either gives you a failure or all results, different behavior should be in a different helper. DeferredList is effectively deprecated so let's not try and fix anything.

Note: See TracTickets for help on using tickets.