Changes between Initial Version and Version 1 of Ticket #13769, comment 27


Ignore:
Timestamp:
Apr 6, 2012, 12:26:56 AM (7 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13769, comment 27

    initial v1  
    11Adam, can you provide a test case (less than 750K)?    As I said above, circular dependency is not a bug, so if something isn't working then that indicates a bug somewhere else than the DOM code.   @rbackhouse's suggestion should not be necessary, as he himself said above in comment {{{#18}}}.
    22
    3 It's also hard to tell if zynevich's patch truly removes the circular dependency, since the modules are still using export.   I'm going to check that.
     3Note: After zynevich's patch, the dependencies between the dom* modules are:
     4
     5{{{
     6_dom-prop-names --> no dependencies
     7dom --> no dependencies
     8dom-class --> "./dom"
     9dom-form --> "./dom"
     10dom-style --> "./dom"
     11dom-attr --> "./dom", "./dom-style",  "./_dom-prop-names"
     12dom-construct --> "./dom", "./dom-attr",
     13dom-geometry --> "./dom", "./dom-style"
     14dom-prop --> "./dom", "./dom-style", "./dom-construct", "./_dom-prop-names"
     15}}}
     16
     17So it does resolve the circular dependency.