scrollable.js incompatible with AMD, breaks load

[bill]

The problem in #13688 can be more simply and consistently reproduced with the attached demo.html file, which simply requires _ScrollableMixin.js. The problem is in scrollable.js, which has this strange code:

if(typeof dojo === "undefined"){
	dojo = {doc:document, global:window};
	dojox = {mobile:{}};

	dojo.has = function(name){
		var ua = navigator.userAgent;
		if(name === "webkit"){
			return ua.indexOf("WebKit") != -1;
		}
		if(name === "android"){
			return parseFloat(ua.split("Android ")[1]) || undefined;
		}
		if(name === "ie"){
			return parseFloat(ua.split("MSIE ")[1]) || undefined;
		}
		if(name === "touch"){
			return (typeof dojo.doc.documentElement.ontouchstart != "undefined" &&
				navigator.appVersion.indexOf("Mobile") != -1) || !!dojo.has("android");
		}
	};
...

That code is meant to only run when dojo.js doesn't exist, but it's running in the AMD case, apparently due to a race condition. Probably it's running before kernel.js.

[bill]

test file

[bill]

simplified _ScrollableMixin.js that still reproduces problem

[ykami]

Thank you for finding this. As you suggested, checking the global 'define' instead of 'dojo' seems to solve the problem.

[ykami]

In [26383]:

Fixes #13768 !strict. Checks the global 'define' rather than 'dojo' to detect whether dojo.js is loaded or not.