Opened 8 years ago

Closed 8 years ago

#13763 closed task (fixed)

dojo/dnd/move.js references undefined variables

Reported by: tomc974 Owned by: Eugene Lazutkin
Priority: high Milestone: 1.8
Component: DnD Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

At the end of dojo/dnd/move.js there is this block of code :

// patching functions one level up for compatibility

dojo.dnd.constrainedMover = dojo.dnd.move.constrainedMover;
dojo.dnd.boxConstrainedMover = dojo.dnd.move.boxConstrainedMover;
dojo.dnd.parentConstrainedMover = dojo.dnd.move.parentConstrainedMover;

I think it should be removed since the affected objects don't exist anymore. they have been remove in 1.6.

Change History (3)

comment:1 Changed 8 years ago by bill

Those functions were removed in [23878], as part of #11775, although they probably shouldn't have been since are apparently a public API. Luckily no one complained.

comment:2 Changed 8 years ago by Eugene Lazutkin

These functions were deprecated long time ago, and shims were created for compatibility. I believe that the documentation doesn't even include old things.

PS: IIRC, dojo.depricated() was not used to reduce the noise in otherwise normal module.

comment:3 Changed 8 years ago by bill

Milestone: tbd1.8
Resolution: fixed
Status: newclosed

I removed them in [26959] so we can mark this as fixed.

Note: See TracTickets for help on using tickets.