Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13754 closed defect (fixed)

android 'has' tests fail

Reported by: ykami Owned by: ykami
Priority: high Milestone: 1.7
Component: DojoX Mobile Version: 1.7.0b1
Keywords: 1.7-mobile Cc: Atsushi Ono, Kris Zyp
Blocked By: Blocking:

Description

[25992] introduced a new has test for android, which wins over the one in dojox.mobile, and android tests in dojox.mobile no longer work correctly because it needs android version number.

Change History (5)

comment:1 Changed 8 years ago by ykami

I know the policy for has tests is to return only true or false, but (at least in 1.7) dojox.mobile needs version number from has tests.

comment:2 Changed 8 years ago by ykami

Resolution: → fixed
Status: new → closed

In [26355]:

Fixes #13754 !strict. Added the 'force' option to has.add to replace the existing tests.

comment:3 Changed 8 years ago by ykami

Summary: android tests fails → android 'has' tests fail

comment:4 Changed 8 years ago by bill

Cc: Kris Zyp added

Actually, many of the browser tests in dojo/_base/sniff.js return a number (ex: isFF, isIE, isSafari), isAndroid can too.

comment:5 Changed 8 years ago by bill

In [26356]:

Make isAndroid and has("android") be a version number rather than a boolean, similar to isIE/has("ie"), refs #13754.

Note: See TracTickets for help on using tickets.