Opened 8 years ago

Closed 8 years ago

#13748 closed defect (invalid)

Error in dijit.form.ComboBoxMixin.labelFunc() when returned value is undefined.

Reported by: vaelen Owned by: bill
Priority: high Milestone: tbd
Component: Dijit - Form Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Ticket #9354 changed the labelFunc() method in dijit.form.ComboBoxMixin? to call toString() on the value of the datastore item because dojox.data.XmlStore? returns an XmlItem? instance instead of a string.

However, there is no check to make sure that the value isn't undefined before calling toString(). If the value is indeed undefined, then an error is thrown when the code tries to call toString() on an undefined value.

Please see the attached patch for a resolution to this issue.

Attachments (1)

patch.txt (755 bytes) - added by vaelen 8 years ago.
Patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by vaelen

Attachment: patch.txt added

Patch

comment:1 Changed 8 years ago by Douglas Hays

Owner: changed from Douglas Hays to bill

comment:2 Changed 8 years ago by bill

I've never seen a case where the value is undefined, when/why is that happening for you?

comment:3 Changed 8 years ago by bill

Resolution: invalid
Status: newclosed

Closing due to no response.

Note: See TracTickets for help on using tickets.