AccordionContainer: addChild broken by textNodes and comments

[Karl Tiedt]

If AccordionContainer? is the child of a widgetsInTemplate widget and the template is not laid out perfectly... (arguable term since perfect is the horrendous looking format that requires opening and closing tags on separate lines to prevent spurious textNodes)

when addChild does insertBefore() it uses childNodes[] which includes textNodes and commentNodes (which arent valid children) and then inserts the new child before them instead of the valid children.

[bill]

_Container.addChild() is supposed to handle this by calling getChildren() (which will ignore text nodes since they aren't widgets), and then used the returned children to execute a call like dojo.place(newNode, refNode, "after").

So, please attach a test case, thanks.

[bill]

Nevermind, I made one. As Karl said on IM, after the AccordionContainer is started, it doesn't call _Container.addChild() but rather executes custom code.

[bill]

In [26354]:

Fixes to AccordionContainer.addChild() for numeric insert index after AccordionContainer is started, and when it contains stray text nodes. Fixes #13741 !strict.