Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13740 closed defect (fixed)

dijit.ColorPalette: When Jaws reads the table there is no summary

Reported by: Katie Vance Owned by: Katie Vance
Priority: high Milestone: 1.7
Component: Accessibility Version: 1.6.1
Keywords: a11y, jaws Cc: Becky Gibson
Blocked By: Blocking:

Description

When JAWS reads the color palette, it just reads the colors without any explanation.

Attachments (1)

13740.patch (2.5 KB) - added by Katie Vance 8 years ago.
Allow user to specify a grid summary

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Becky Gibson

Looks good to me as long as JAWS is happy. Although, I wouldn't add in a default summary - make the user responsible for adding the appropriate, localized text. Just my two cents :-)

comment:2 Changed 8 years ago by Katie Vance

The default is actually no summary. Then if the user needs a summary, they can specify. I didn't want to require a summary because that would break existing widgets.

comment:3 Changed 8 years ago by bill

Couple things on the patch:

  1. Can't you just use
_setPaletteSummaryAttr: "paletteTableNode"

rather than that special setting code?

  1. Like all widget parameters, paletteSummary needs an API doc comment with the description of what it is

Other than that seems good, although I note that things like Editor's foreground/background color pickers still won't announce a summary. Maybe that's OK since they are spawned from a DropDownButton that has a label?

comment:4 Changed 8 years ago by Katie Vance

Fixed patch accordingly. I also tried the color palette in the editor and because the button had a description it was not confusing to the user what the content was in the color palette. I think it is ok that the summary isn't read in those instances.

comment:5 Changed 8 years ago by bill

Milestone: tbd1.7

OK thanks, looks good except you need an API comment for summary so it shows up in the API documentation (same as all widget attributes).

About the roles, since this table is composed of actual <table> and <td> nodes, do we need role=grid and role=gridcell at all?

comment:6 Changed 8 years ago by bill

PS: thanks to #12377 admittedly we don't document "obvious" attributes to widgets like HTML5 or aria settings, not sure if summary falls into that category or not.

Changed 8 years ago by Katie Vance

Attachment: 13740.patch added

Allow user to specify a grid summary

comment:7 Changed 8 years ago by Katie Vance

Added summary attribute to the widget. Also added test case for set. I added the roles of grid and gridcell because without them, the colors were not being announced for certain browsers.

comment:8 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

In [26414]:

Add ability to specify a summary on ColorPalette and other _PaletteMixin based widgets so that screen-reader users know what the ColorPalette is for. Similar to labels on form fields, except it doesn't appear visually. Thanks Katie, fixes #13740 !strict.

comment:9 Changed 8 years ago by Adam Peller

In [26591]:

Refs #13740 disable log file again

comment:10 Changed 8 years ago by Adam Peller

[26591] was actually for #13710

Note: See TracTickets for help on using tickets.