Changes between Initial Version and Version 1 of Ticket #13733


Ignore:
Timestamp:
Aug 23, 2011, 4:12:36 AM (9 years ago)
Author:
Kenneth G. Franqueiro
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13733

    • Property Status changed from new to assigned
  • Ticket #13733 – Description

    initial v1  
    1 A few days I unwittingly checked in some changes which replaced a bunch of `dojo.isQuirks` references with `has("quirks")` references.  It was quickly brought to my attention by Bill that the reason `isQuirks` had been left alone was because `withDoc` and `withGlobal` update it, but they don't update the value of the respective `has` feature.
     1A few days ago, I unwittingly checked in some changes which replaced a bunch of `dojo.isQuirks` references with `has("quirks")` references.  It was quickly brought to my attention by Bill that the reason `isQuirks` had been left alone was because `withDoc` and `withGlobal` update it, but they don't update the value of the respective `has` feature.
    22
    33In the e-mail thread that followed, I discovered that it should actually be trivial to update the value of the `has` feature as well as `isQuirks`; moreover, this type of updating has never been done for `isIE` (or `has("ie")`), despite the potential for `withDoc` or `withGlobal` to be pointed to a document running in a different IE compatibility mode.