Opened 8 years ago

Closed 3 years ago

#13731 closed enhancement (patchwelcome)

dojo.dnd needs html5 attributes

Reported by: Colin Snover Owned by: Eugene Lazutkin
Priority: high Milestone: 1.13
Component: DnD Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently it uses two nonstandard attributes on children, dndType and dndData.

I’m not sure if it makes more sense to look for a single data-dojo-props (easier, more extensible, but maybe that attribute is supposed to be reserved for the parser only), or if it should actually use separate data-dojo-dnd-type and data-dojo-dnd-data attributes.

In any case, if we’re transitioning to HTML5-valid attrs on everything, this needs them.

Change History (2)

comment:1 Changed 7 years ago by Eugene Lazutkin

How to handle it better? I am open to suggestions. Obviously I want the proposed solution to be in line with our current parser practices.

comment:2 Changed 3 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

I would say data-dojo-dnd-propos or data-dojo-props.

That said, I'm going to close as patchwelcome given the ticket has been untouched in 4 years.

Note: See TracTickets for help on using tickets.