Calendar: No auditive indication for selected and disabled days

[Katie Vance]

Add aria-selected and aria-disabled onto the gridcell.

[bill]

Thanks. Are the false settings necessary or useful?

template.setAttribute("aria-selected", false);

and

template.setAttribute("aria-disabled", false);

It seems like if there was no setting at all it would imply that the cell was enabled but unselected.

[Katie Vance]

According to ​http://www.w3.org/TR/wai-aria/states_and_properties, if aria-selected is not set, then it defaults to the element is not selectable. So I think we should be setting it to false. However, for aria-disabled the default value is the same as if it were set to false, so I think we can just remove the attribute when it's false. I updated the patch with that change.

[bill]

Presumably you don't need the template.removeAttribute("aria-disabled"); because that attribute isn't there to begin with? Even when you switch from one month to another I thought it would start from scratch, but please check.

Also, please update the tests (probably Calendar_a11y.html) to check these roles. Similar to how Dialog_a11y.html does it.

[Katie Vance]

I tested it out and we must remove "aria-disabled", otherwise it will still be there if a user enables them again. I will add test cases to the patch.

[Katie Vance]

Update patch to include robot test cases.

[bill]

Looks good to me, I'll check this in.

[bill]

Actually, the regression test fails on IE8.

[Katie Vance]

Test case has been fixed

[Katie Vance]

I added the case for aria-disabled to be false. It's valid for a disabled element to have it as false, however, it will never likely be that way since the code removes it instead of setting it to false.

[bill]

In [26376]:

Calendar fixes so JAWS announces selected and disabled days, thanks Katie, fixes #13722 !strict.

[bill]

This isn't working on IE6, Calendar_a11y.html fails with:

GROUP "aria" has 1 test to run
_AssertFailure: [object Error]: assertEqual() failed: expected false but got false with hint: aria-selected should be false at startup

[Adam Peller]

moved to 1.7.1 for consideration. Please move to 1.8 as appropriate.

[Adam Peller]

actually moving to 1.7.1

[bill]

In [26952]:

So-called "boolean" aria attributes aria-selected, aria-pressed, aria-checked, aria-disabled etc. should actually be strings of "true" or "false", rather than boolean values, as per spec at ​http://www.w3.org/TR/wai-aria/appendices#typemapping.

Fixes #13722 !strict.