Opened 10 years ago
Closed 9 years ago
#13722 closed defect (fixed)
Calendar: No auditive indication for selected and disabled days
Reported by: | Katie Vance | Owned by: | Becky Gibson |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | Accessibility | Version: | 1.6.1 |
Keywords: | a11y, jaws | Cc: | Becky Gibson |
Blocked By: | Blocking: |
Description
Add aria-selected and aria-disabled onto the gridcell.
Attachments (1)
Change History (16)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
According to http://www.w3.org/TR/wai-aria/states_and_properties, if aria-selected is not set, then it defaults to the element is not selectable. So I think we should be setting it to false. However, for aria-disabled the default value is the same as if it were set to false, so I think we can just remove the attribute when it's false. I updated the patch with that change.
comment:3 Changed 10 years ago by
Presumably you don't need the template.removeAttribute("aria-disabled");
because that attribute isn't there to begin with? Even when you switch from one month to another I thought it would start from scratch, but please check.
Also, please update the tests (probably Calendar_a11y.html) to check these roles. Similar to how Dialog_a11y.html does it.
comment:4 Changed 10 years ago by
I tested it out and we must remove "aria-disabled", otherwise it will still be there if a user enables them again. I will add test cases to the patch.
comment:6 Changed 10 years ago by
Milestone: | tbd → 1.7 |
---|---|
Summary: | dijit.Calendar - No auditive indication for selected and disabled days → Calendar: No auditive indication for selected and disabled days |
Looks good to me, I'll check this in.
Changed 10 years ago by
Attachment: | 13722.patch added |
---|
comment:9 Changed 10 years ago by
I added the case for aria-disabled to be false. It's valid for a disabled element to have it as false, however, it will never likely be that way since the code removes it instead of setting it to false.
comment:11 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This isn't working on IE6, Calendar_a11y.html fails with:
GROUP "aria" has 1 test to run
_AssertFailure: [object Error]: assertEqual() failed: expected false but got false with hint: aria-selected should be false at startup
comment:12 Changed 9 years ago by
moved to 1.7.1 for consideration. Please move to 1.8 as appropriate.
comment:14 Changed 9 years ago by
Milestone: | 1.7.1 → 1.8 |
---|
Thanks. Are the false settings necessary or useful?
and
It seems like if there was no setting at all it would imply that the cell was enabled but unselected.