dojo.data.ObjectStore delete error on

[Bo Lorentsen]

When using ObjectStore? for adding new elements (newItem), and end up removing these very same objects again, before saving the store, we end up having an reference error in the save function when trying to save this store.

The reason are related to the dirty.old (loop at line 411), that will be set to false in this situation, and not an object, and this ends up making the code search for an (id) attribute in the false value, and that ends up in an exception.

[Bo Lorentsen]

This may be a fix for the problem at hand

[bill]

Druppy - generally you need to add a test case to tickets, an html file that reproduces the problem. Also, thanks for the patch, but please file a ​cla before attaching patches or else we can't look at them.

[Bo Lorentsen]

Ok, noted ... I will sign an CLA as quickly as possible.

[Kris Zyp]

In [26499]:

Fix identity determination and immediate deletion after creation error, fixes #13715 !strict

[bill]

This change breaks AMD and ComboBox. You are referencing the "dojo" global and your module isn't returning a value. Also, why are you extending Evented?

[Kris Zyp]

In [26571]:

Fix merge issue with declaration and avoid duplicate store notification events, refs #13715 !strict

[Kris Zyp]

Is there a test case that is failing with the change? I didn't see any breakages using _autoComplete.html.

As far as Evented, ObjectStore? is a data store, so it emits events, and therefore it extends Evented. It emits "New", "Set", and "Delete".

[bill]

Replying to kzyp:

Is there a test case that is failing with the change? I didn't see any breakages using _autoComplete.html.

For future reference, you need to look at the robot test scripts that control the top level (non-automated) test file, in this case tests/form/robot/!ComboBox_a11y.html and !ComboBox_mouse.html.

But anyway you fixed the problem by fixing that merge error.