Opened 8 years ago

Closed 6 years ago

#13706 closed defect (wontfix)

dojox.color.fromHsl L stands for lightness not luminosity

Reported by: Enzo Owned by: Tom Trenka
Priority: low Milestone: 2.0
Component: Dojox Version: 1.6.1
Keywords: reviewed Cc:
Blocked By: Blocking:

Description

Just a notice in fromHsl() code (dojox/color/_base.js)

The L of HSL stands for lightness, and not for luminosity (however used in fromHsl code) You can check this at: http://en.wikipedia.org/wiki/HSL_and_HSV

Further more, in ticket #13705, the toHsl was giving a bad result (I think it's bad) => are you sure about the implementation of fromHsl ?

In fact, I'm using implementation from http://www.easyrgb.com/index.php?X=MATH&H=19#text19, which differs from dojo implementation for fromHsl

Change History (7)

comment:1 Changed 8 years ago by bill

Cc: Tom Trenka added
Owner: set to Eugene Lazutkin

Not sure who this should go to, maybe Eugene?

comment:2 Changed 8 years ago by Adam Peller

Component: GeneralDojox

comment:3 Changed 8 years ago by bill

Cc: Tom Trenka removed
Owner: changed from Eugene Lazutkin to Tom Trenka

From the comment in #13705 I'm guessing this is also ttrenka's. (Although just a guess.)

comment:4 Changed 8 years ago by Tom Trenka

Milestone: tbd1.8
Priority: highlow
Status: newassigned

comment:5 Changed 7 years ago by Tom Trenka

Keywords: reviewed added

comment:6 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 has been tagged; moving all outstanding tickets to next major release milestone.

comment:7 Changed 6 years ago by Tom Trenka

Resolution: wontfix
Status: assignedclosed

Given the age of these tickets and the small nature of them, I'm marking all as won't fix. #1395 was somewhat addressed with the implementation of SHA2 in DTK 1.8.

Note: See TracTickets for help on using tickets.