Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13702 closed defect (fixed)

dojo.dnd.Target and dojo.dnd.AutoSource are inaccessible via AMD

Reported by: Colin Snover Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: DnD Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

They are all defined inside dojo/dnd/Source.js. Since the definitions can‘t be moved without causing a backwards compatibility circular dependency disaster, this patch just creates some shim files until the definitions can be moved in 2.0.

Attachments (1)

dojo.dnd.amd-target.patch​ (696 bytes) - added by Colin Snover 8 years ago.
Add shims for dojo.dnd.Target and dojo.dnd.AutoSource?

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Colin Snover

Attachment: dojo.dnd.amd-target.patch​ added

Add shims for dojo.dnd.Target and dojo.dnd.AutoSource?

comment:1 Changed 8 years ago by bill

Resolution: → fixed
Status: new → closed

In [26262]:

Make AutoSource and Target available via AMD. Although these classes are versy small, since they are used as widgets, seems good to make them separate files, so that IDE's can (easily) auto-generate require statements for them. Fixes #13702 !strict.

comment:2 Changed 8 years ago by bill

Milestone: tbd → 1.7

comment:3 Changed 8 years ago by bill

In [26265]:

Don't make AutoSource and Target hang off of Source, but still pull them in automatically for non-AMD applications. Refs #13702 !strict.

Note: See TracTickets for help on using tickets.