Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1370 closed defect (fixed)

Editor2 (this.contextMenu) destroy error/bug

Reported by: tnoogen@… Owned by: liucougar
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Editor2, Editor2Plugin, ContextMenu Cc: tnoogen@…
Blocked By: Blocking:

Description

In srcwidgetEditor2PluginContextMenu.js, I get this error that this.contextMenu is undefined in both IE and Firefox.

I've attach the patch below. I don't know the reason behind disposing this.contextMenu so it might not be the best way to do it. Because contextMenu is never created or was destroyed somewhere already?

To recreate:

  1. visit http://archive.dojotoolkit.org/nightly/tests/widget/test_Editor2.html
  2. click button "clobber the editor"

Note:

In IE: must have script debugging enabled. In FF: view javascript console.

--- Patch Index: ContextMenu?.js =================================================================== --- ContextMenu?.js (revision 5435) +++ ContextMenu?.js (working copy) @@ -90,8 +90,11 @@

this.editor.unregisterLoadedPlugin(this); delete this.groups; delete this.separators;

  • this.contextMenu.destroy();
  • delete this.contextMenu;

+ if (this.contextMenu) + { + this.contextMenu.destroy(); + delete this.contextMenu; + }

}

});

Attachments (1)

Editor2Plugin_ContextMenu.patch (444 bytes) - added by guest 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by guest

comment:1 Changed 13 years ago by liucougar

Cc: tnoogen@… added
Owner: changed from bill to liucougar
Version: 0.40.3

comment:2 Changed 13 years ago by liucougar

Resolution: fixed
Status: newclosed

(In [5440]) fixes #1370: Editor2 (this.contextMenu) destroy error/bug fix: plugins and editor2toolbar are destroyed twice fix: after closing of editor2, the original textarea should be shown

comment:3 Changed 13 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.