Changes between Version 1 and Version 2 of Ticket #13699, comment 2


Ignore:
Timestamp:
Aug 16, 2011, 4:46:46 PM (8 years ago)
Author:
Colin Snover
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13699, comment 2

    v1 v2  
    22
    33Also, the return value change doesn’t make sense; it should be building an object and assigning the object to dojo.fx and returning the same object, otherwise people can’t hot patch properly.
     4
     5Finally as I mentioned in another ticket, as pointed out by kgf, your change to remove “dojo.” from the comment on line 20 probably breaks the doc parser.