Changes between Version 1 and Version 2 of Ticket #13699, comment 2
- Timestamp:
- Aug 16, 2011, 4:46:46 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13699, comment 2
v1 v2 2 2 3 3 Also, the return value change doesn’t make sense; it should be building an object and assigning the object to dojo.fx and returning the same object, otherwise people can’t hot patch properly. 4 5 Finally as I mentioned in another ticket, as pointed out by kgf, your change to remove “dojo.” from the comment on line 20 probably breaks the doc parser.