Changes between Initial Version and Version 1 of Ticket #13699, comment 2


Ignore:
Timestamp:
Aug 16, 2011, 4:46:11 PM (8 years ago)
Author:
Colin Snover
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13699, comment 2

    initial v1  
    11This patch violates !JavaScript (& Dojo) code conventions. Uppercase first letters are reserved for constructors (dom, array, etc. are not constructors) and uppercase letters in other places in variables are reserved for delineating word breaks in variable names (i.e. thisDomThing not thisDOMThing). Please fix at your earliest convenience. Thanks!
     2
     3Also, the return value change doesn’t make sense; it should be building an object and assigning the object to dojo.fx and returning the same object, otherwise people can’t hot patch properly.