Opened 8 years ago

Closed 8 years ago

#13687 closed defect (fixed)

mobileCharting demo is broken on trunk

Reported by: Ming Zhe Huang Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: Charting Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Check: http://archive.dojotoolkit.org/nightly/checkout/demos/mobileCharting/demo.html

Click list item to any chart, and you'll find that plot area is squeezed into a line.

Attachments (1)

dojox.charting.setMarginBox.patch (639 bytes) - added by cjolif 8 years ago.
Chart.js patch to fix regression on mobileCharting demo

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by cjolif

I'll have a look at this, are you reproducing both on mobile and desktop (I reproduce on FF, but don't have a mobile available right now to test)?

Last edited 8 years ago by cjolif (previous) (diff)

comment:2 Changed 8 years ago by cjolif

The regression was probably introduce in http://bugs.dojotoolkit.org/browser/dojo/dojox/trunk/charting/Chart.js?rev=25968 I think Chart.resize should use domGeom.setMargingBox not getMarginBox for the 2 first calls. I'll double check and prepare a patch.

Changed 8 years ago by cjolif

Chart.js patch to fix regression on mobileCharting demo

comment:3 Changed 8 years ago by bill

Milestone: tbd1.7

Good catch, I'll check that in.

comment:4 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

In [26225]:

fix typo from baseless conversion, thanks cjolif, fixes #13687, refs #12863 (specifically [25968]), !strict

Note: See TracTickets for help on using tickets.