Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13680 closed defect (fixed)

Missing dependency errors when running build without tests or without dojox

Reported by: Kenneth G. Franqueiro Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.7.0b1
Keywords: build Cc:
Blocked By: Blocking:

Description

There are a few errors reported by the build process if you run a build with mini=true, or with mini=false and a profile that does not include dojox.

With mini=true:

error(311) Missing dependency. module: dojo/robot; dependency: doh/_browserRunner error(311) Missing dependency. module: dojo/robot; dependency: doh/robot

With mini=false and no dojox prefix (e.g. profile=base):

error(311) Missing dependency. module: doh/runner; dependency: dojox/math/stats

Both of these can be reproduced by running a build against the base profile, setting mini as appropriate.

I'm not sure whether these errors are actually nothing new and can be safely ignored; the 1.6 build system didn't seem to report anything like this, which is why I'm reporting it here as a potential 1.7 issue.

Also possibly worth noting, I get this error all the time:

error(307) Failed to evaluate module tagged as pure AMD (fell back to processing with regular expressions). module: dojo/testModule; error: ReferenceError: "document" is not defined.

Change History (6)

comment:1 Changed 8 years ago by bill

Listed these in #13466 too.

comment:2 in reply to:  1 Changed 8 years ago by Kenneth G. Franqueiro

Replying to bill:

Listed these in #13466 too.

I see the two I noted running into with mini=true there, but not the others. (Just pointing out, to avoid this getting prematurely flagged as a duplicate/subset)

I'm a bit concerned about doh relying on dojox, not sure if that's new or perhaps as old as the perf stuff (1.4?).

comment:3 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:4 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [26702]:

tag dojo/robot* resources as test resources; fixes #13680

comment:5 Changed 8 years ago by Rawld Gill

In [26703]:

moved dojox/math/stats module to section in DOH that uses it; thereby eliminating a hard dependency; further fixes #13680; !strict

comment:6 Changed 8 years ago by Rawld Gill

Note that dojox/math/stats is only used for perf tests which also include a number of additional dojox modules. In [26703] I moved dojox/math/stats dependency to section of code that conditionally injects the perf test support. This eliminates the hard requirement for dojox when doh is included in a build...it seems like a lot to include all of dojox when it will rarely be used. If you want to run the perf tests on built code then you must either copy over dojox or include dojox in the build explicitly.

Note: See TracTickets for help on using tickets.