Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#1368 closed enhancement (fixed)

Build option to remove console.* statements

Reported by: Michael Schall Owned by: James Burke
Priority: high Milestone: 1.2
Component: BuildSystem Version: 0.3
Keywords: Cc: James Burke
Blocked By: Blocking:

Description

I just found the wonder of the dojo.profile namespace. I would like to add profile statements to all my widgets/modules. It would be great if the build system would remove them from the dojo.js file. Personally I would like to leave them in the rest of the release folder. Is the rest even even "built"?

Change History (13)

comment:1 Changed 13 years ago by dylan

Milestone: 0.4

Perhaps we can do this as part #1357 ?

comment:2 Changed 13 years ago by dylan

Milestone: 0.40.5

unfortunately not going to make it into 0.4, pushing to 0.5

comment:3 Changed 12 years ago by Adam Peller

Cc: James Burke added
Milestone: 0.91.1

We don't have dojo.profile anymore, but there are profiling options on console, and we could possibly remove all console.* references in a build. Should we do this? This doesn't sound like a 0.9 thing.

comment:4 Changed 12 years ago by dante

i'm +1 automatically stripping console.log/dir from the code in release builds (or any build for that matter?) ... they are helpful to in test cases, but have limited use within the codebase on a permanent basis.

comment:5 Changed 12 years ago by dylan

Summary: Build option to remove dojo.profile statementsBuild option to remove console.* statements

comment:6 Changed 12 years ago by Adam Peller

I'm -1 on removing some of the console.* statements, like console.error/warning. log and debug seem okay, but we need a 'style' statement about this before we change the build.

comment:7 Changed 12 years ago by dylan

Milestone: 1.11.2

ok, will push out until we decide on a preferred approach.

comment:8 Changed 12 years ago by James Burke

For this to work well, I'll need the parens-matching code needed for #2536.

comment:9 Changed 12 years ago by James Burke

Owner: changed from alex to James Burke

Stealing from alex so it shows up in my bug search. Feel free to take it back if you really want it.

comment:10 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed

Fixed in r14254.

comment:11 Changed 11 years ago by James Burke

(In [14256]) Refs #1368: make sure console calls are still useful outside of built files that have the calls stripped.

comment:12 Changed 11 years ago by James Burke

(In [14258]) Refs #1368: make sure xdomain warnings are really warnings.

comment:13 Changed 11 years ago by James Burke

(In [14260]) Refs #1368: make sure xdomain warnings are really warnings. \!strict

Note: See TracTickets for help on using tickets.