Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13670 closed defect (fixed)

dijit,popup._createWrapper function returns 'true' rather than the wrapper widget

Reported by: bill Owned by: bill
Priority: high Milestone: 1.6.2
Component: Dijit Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

(from David Chang)

Hello,

I upgraded the Dojo 1.6 4/20 build to the latest 1.6 build and I'm getting an error from a dijit popup.moveOffScreen call.

I found the root of the problem is in the dijit popup class's _createWrapper method on the following line:

var wrapper = widget.declaredClass ? widget._popupWrapper : (widget.parentNode && dojo.hasClass(widget.parentNode, "dijitPopup")),
node = widget.domNode || widget;

after this line wrapper is = true and then that is what is returned, on which the CSS property 'visability' is attempted to be set, which results in the original error I saw.

Change History (3)

comment:1 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

In [26170]:

Fix bug where popup._createWrapper() returned true rather than the wrapper DOMNode, leading to errors down the road. Fixes #13670 !strict. Tests on IE8 pass except for pre-existing failures in !TooltipDialog_a11y.html and editor.robot.FullScreen.

comment:2 Changed 8 years ago by bill

In [26171]:

fix trailing comma, refs #13670

comment:3 Changed 8 years ago by bill

In [26172]:

#13670 isn't an issue on trunk, but porting the test over from 1.6 branch, and fixing another issue that the test exposes. Refs #13670 !strict.

Note: See TracTickets for help on using tickets.