Opened 10 years ago

Closed 10 years ago

#13656 closed defect (fixed)

ComboBox allows ENTER to bubble up

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:


Pressing ENTER in a ComboBox? while selecting a value from the dropdown does a preventDefault but not a stopEvent, allowing the event to bubble up and cause problems with parent event handlers.

Change History (2)

comment:1 Changed 10 years ago by Douglas Hays

Refs [10023]

comment:2 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

In [26153]:

Fixes #13656. Instead of preventDefault for ENTER, call event.stop so that an upstream element doesn't see the ENTER. InlineEditBox? still sees the ENTER since it just connects to the editing widget's _onKeyPress and the event disposition has no bearing on that. This is different than Dojo 0.9 when the stopEvent was changed to preventDefault.

Note: See TracTickets for help on using tickets.