Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13649 closed defect (fixed)

NodeList test failures (IE8)

Reported by: bill Owned by: Kris Zyp
Priority: high Milestone: 1.7
Component: Query Version: 1.6.1
Keywords: dohfail Cc:
Blocked By: Blocking:

Description

Starting with [25889] the NodeList.html test fails. Tested on IE8. Failures in slice, concat, etc.

Change History (8)

comment:1 Changed 10 years ago by bill

Also, NodeList-fx, wipeIn and wipeOut tests.

comment:2 Changed 10 years ago by Kris Zyp

Hmm, I am not see this error. Do you think the feature test is wrong for testing for the ability to create delegated arrays?

comment:3 Changed 10 years ago by bill

Did you mean that you didn't see the errors on IE8?

I can check what the feature test is returning for IE8 later.

comment:4 Changed 10 years ago by Kris Zyp

Yes, I didn't see any errors. Sorry for the typos/bad english.

comment:5 Changed 10 years ago by bill

Hmm, well the first failure I'm getting is on the slice() test, in the expression:

pnl.slice(1).end()

slice() returns a plain array, and plain arrays don't have an end() method, so it fails.

What happens when you run http://bill.dojotoolkit.org/trunk/dojo/tests/_base/NodeList.html on IE8?

comment:6 Changed 10 years ago by Kris Zyp

In [26248]:

Fix array extension support in IE 8, refs #13649 !strict

comment:7 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

Thanks, that fixes it, what was your issue reproducing the problem before?

I see Mark also reproduced the problem and put the fix in http://thread.gmane.org/gmane.comp.web.dojo.devel/15373/focus=15425, I'm not sure why it didn't reproduce for you, if you did indeed try on IE8. Please be sure to test on IE8 before checkins.

Last edited 10 years ago by bill (previous) (diff)

comment:8 Changed 10 years ago by Kris Zyp

Apparently IE9's emulation of IE8 doesn't include the property shadow bug, even though it does include the extended array length property bug.

Note: See TracTickets for help on using tickets.