Opened 10 years ago

Closed 10 years ago

#13647 closed defect (fixed)

[patch] making dojo/_base/xhr baseless

Reported by: zhangyp Owned by: bill
Priority: blocker Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

This patch makes dojo/_base/xhr baseless and depend on minimal modules. It passed unit test dojo/tests/_base/xhr.js after the patch was applied.

Attachments (2)

xhr.patch​ (11.3 KB) - added by zhangyp 10 years ago.
xhr2.patch​ (627 bytes) - added by zhangyp 10 years ago.
fix to the regression in ie

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by zhangyp

Attachment: xhr.patch​ added

comment:1 Changed 10 years ago by bill

Owner: set to bill
Resolution: → fixed
Status: new → closed

In [26148]:

fix dojo/_base/xhr to be baseless, patch from Stephen Zhang (thanks!), fixes #13647 !strict.

comment:2 Changed 10 years ago by Douglas Hays

Priority: normal → highest
Resolution: fixed
Status: closed → reopened

After this patch, it seems all tests throw an exception on IE8 and 9. For example:
dojo/tests/_base/abs.html

comment:3 Changed 10 years ago by zhangyp

I will take a look at this issue on IE8 and 9.

Changed 10 years ago by zhangyp

Attachment: xhr2.patch​ added

fix to the regression in ie

comment:4 Changed 10 years ago by zhangyp

I have fixed the missing "on" dependency for IE. It passed dojo/tests/_base/xhr.js on ie9. I have not ie8 to have a try on. Doug, would you have a try on IE8 and commit the patch if it passed on ie8?

comment:5 Changed 10 years ago by Douglas Hays

Resolution: → fixed
Status: reopened → closed

In [26151]:

Fixes #13647. Added missing on.js dependency.

comment:6 Changed 10 years ago by bill

Milestone: tbd → 1.7
Note: See TracTickets for help on using tickets.