Opened 10 years ago

Closed 10 years ago

#13644 closed defect (fixed)

unused vars in loader.js

Reported by: bill Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

In loader.js starting [25768] there's an unused variable: 

hotDojoRequireResources = {}

Either should just be removed or maybe it indicates a bug? Not sure.

Also, in the code: 

dojoRequirePlugin = function(mid, require, loaded){
	var referenceModule = require.module,
		count = 1,
		arrived = function(){
			if(--count==0){
				loaded(1);
			}
		};

referenceModule is unused.

Next, omitModuleCheck param to dojo.require() is unused: 

dojo.require = function(moduleName, omitModuleCheck) {

Finally,these vars appears to be unused: 

requested =
	loaderVars.requested,
...
fixupUrl =
	loaderVars.fixupUrl,

Change History (4)

comment:1 Changed 10 years ago by bill

Description: modified (diff)
Summary: hotDojoRequireResources var unused → unused vars in loader.js

comment:2 Changed 10 years ago by Rawld Gill

Status: new → assigned

comment:3 Changed 10 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

In [26616]:

removed unused code paths; fixed dojo.require to consume second arg; fixes #13643; fixes #13644; !strict

comment:3 Changed 10 years ago by bill

Milestone: tbd → 1.7
Note: See TracTickets for help on using tickets.