dijit.InlineEditBox property "editing" not watchable
<zimnyx> Is dojo code supposed to use get/set for all public properties? I ask because I tried to dijit.InlineEditBox.watch('editing', ...), but it
cannot work, because its value is set via "widget.editing = ...".
<zimnyx> Am I supposed to file a bug on this issue, or some refactoring is planed to cover it globally ?
<sfoster> zimnyx: I think that's a bug, it probably should be watchable
<sfoster> or at least it seems a reasonable request
<zimnyx> sfoster: I think it's quite common in dojo code...
<sfoster> zimnyx: not every property is supposed to have a setter.
<sfoster> but those that represent a state change probably should
<PEM> zimnyx what dojo version are you using ?
<zimnyx> PEM: 1.6.1
<PEM> you might aswell do a editor.on("onChange", ...
<PEM> ah, but that's only available in 1.7 :)
<PEM> hmm well anyway, it's strange that you cannot access this property, maybe it was not intended to be public ?
<zimnyx> PEM: http://dojotoolkit.org/api/1.6/dijit/InlineEditBox
<zimnyx> it's in API docs mantioned as "Is the node currently in edit mode?"
Change History (2)
Owner: |
set to Douglas Hays
|
Resolution: |
→ fixed
|
Status: |
new →
closed
|
In [26122]: