Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13634 closed defect (fixed)

dijit.InlineEditBox property "editing" not watchable

Reported by: zimnyx Owned by: Douglas Hays
Priority: high Milestone: 1.7
Component: Dijit Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

<zimnyx> Is dojo code supposed to use get/set for all public properties? I ask because I tried to dijit.InlineEditBox.watch('editing', ...), but it 
         cannot work, because its value is set via "widget.editing = ...". 
<zimnyx> Am I supposed to file a bug on this issue, or some refactoring is planed to cover it globally ?
<sfoster> zimnyx: I think that's a bug, it probably should be watchable
<sfoster> or at least it seems a reasonable request
<zimnyx> sfoster: I think it's quite common in dojo code...
<sfoster> zimnyx: not every property is supposed to have a setter.
<sfoster> but those that represent a state change probably should
<PEM> zimnyx what dojo version are you using ?
<zimnyx> PEM: 1.6.1
<PEM> you might aswell do a editor.on("onChange", ...
<PEM> ah, but that's only available in 1.7 :)
<PEM> hmm well anyway, it's strange that you cannot access this property, maybe it was not intended to be public ?
<zimnyx> PEM: http://dojotoolkit.org/api/1.6/dijit/InlineEditBox
<zimnyx> it's in API docs mantioned as "Is the node currently in edit mode?"

Change History (2)

comment:1 Changed 8 years ago by Douglas Hays

Owner: set to Douglas Hays
Resolution: fixed
Status: newclosed

In [26122]:

Fixes #13634. Change javascript assignments of InlineEditBox:editing to use _set to enable watch functionality.

comment:2 Changed 8 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.