Opened 8 years ago

Closed 8 years ago

#13631 closed defect (fixed)

[patch] making dojo/window baseless and use correct module return value

Reported by: zhangyp Owned by: bill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

This patch makes dojo/window baseless and use correct module return value. It passed unit test dojo/tests/window.js after the patch was applied.

Attachments (1)

window.patch (3.9 KB) - added by zhangyp 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by zhangyp

Attachment: window.patch added

comment:1 Changed 8 years ago by zhangyp

changed local variable name of "dojo/_base/sniff" to "has" according to bill's comment.

comment:2 Changed 8 years ago by bill

Milestone: tbd1.7

comment:3 Changed 8 years ago by bill

Owner: set to bill
Resolution: fixed
Status: newclosed

In [26111]:

fix dojo/window to be baseless, patch from Stephen Zhang (thanks!), fixes #13631 !strict.

Note: See TracTickets for help on using tickets.