Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13630 closed defect (fixed)

[patch] making dojo/uacss use correct module return value

Reported by: zhangyp Owned by: bill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

this patch makes dojo/uacss use correct module return value. It passed unit test dojo/tests/uacss after the patch was applied.

Attachments (1)

uacss.patch (2.4 KB) - added by zhangyp 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by zhangyp

Attachment: uacss.patch added

comment:1 Changed 8 years ago by bill

Milestone: tbd1.7

Thanks for the patch, I'll check this in. A few changes:

  • As I said in a few other of your tickets, our convention is to map "dojo/_base/sniff" --> has, so the builder can strip unused code blocks in browser specific builds. Of course if we ever decide to has() return booleans only, all that will change.
  • It seems silly to require "dojo/_base/kernel" just to be able to return "dojo" from the module, so I'll change it to return has. I checked the existing code base and no one is currently using the return value from "dojo/_base/sniff", so changing it isn't an issue.

comment:2 Changed 8 years ago by bill

Owner: set to bill
Resolution: fixed
Status: newclosed

In [26109]:

fix dojo/uacss to be baseless, patch from Stephen Zhang (thanks!), fixes #13630 !strict.

comment:3 Changed 8 years ago by zhangyp

I did not expect the patches been applied in such a short time. :-). I will change the sniff convent in the tickets that is not closed.

comment:4 Changed 8 years ago by bill

No worries, I happened to have some free time today. Thanks for all the patches.

Note: See TracTickets for help on using tickets.