Opened 10 years ago

Closed 10 years ago

#13625 closed defect (fixed)

[patch] making dojo/html use correct module return value

Reported by: zhangyp Owned by: bill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

This patch makes dojo/html use correct module return value. It has passed unit test dojo/tests/html.js after the patch is applied.

Attachments (1)

html.patch​ (4.1 KB) - added by zhangyp 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by zhangyp

Attachment: html.patch​ added

comment:1 Changed 10 years ago by bill

Owner: set to bill
Resolution: → fixed
Status: new → closed

In [26107]:

fix html to have granular dependencies and be baseless, patch from Stephen Zhang (thanks!), fixes #13625 !strict.

comment:2 Changed 10 years ago by bill

Milestone: tbd → 1.7

comment:3 Changed 10 years ago by bill

Resolution: fixed
Status: closed → reopened

Uh oh, after [26107] the Dialog_mouse.html (in dijit/tests/robot) fails on FF5/win, 2 failures with hint "focus cleared".

comment:4 Changed 10 years ago by bill

The above checkin ([26107]) was not broken per-se, but exposed a problem in focus.js. See [26179] for start of solution to this.

Last edited 10 years ago by bill (previous) (diff)

comment:5 Changed 10 years ago by bill

Resolution: → fixed
Status: reopened → closed

In [26185]:

Since app code can call domGeometry.empty() etc. directly, need to connect there instead of on dojo.empty(). Fixes Dialog_mouse.html test failures. Refs #9641, fixes #13625 !strict. See also [26107] which enables a single on() call to monitor both dojo.empty() and domConstruct.empty() calls.

Note: See TracTickets for help on using tickets.