Opened 8 years ago

Closed 8 years ago

#13624 closed defect (fixed)

[patch] making dojo/hash reference to correct module return value

Reported by: zhangyp Owned by: bill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

This patch makes dojo/hash reference to correct module return value. It passed unit test dojo/test/hash.js after the patch is applied.

Attachments (1)

hash.patch (2.9 KB) - added by zhangyp 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by zhangyp

Attachment: hash.patch added

comment:1 Changed 8 years ago by bill

Milestone: tbd1.7

Thanks, I'll check this in but note that our convention is to use "has" for the return value of sniff.js, so that the builder can be used to trim unwanted browser-specific code paths. So I'll change that part.

comment:2 Changed 8 years ago by bill

Owner: set to bill
Resolution: fixed
Status: newclosed

In [26104]:

fix hash to be baseless, patch from Stephen Zhang (thanks!), fixes #13624 !strict.

Note: See TracTickets for help on using tickets.