Opened 8 years ago

Closed 8 years ago

#13620 closed defect (fixed)

[patch] making dojo/colors reference correct module return value

Reported by: zhangyp Owned by: bill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

This patch makes dojo/colors reference correct module return value. After the patch is applied, the unit test "dojo/tests/colors.js" behave the same as before (13 out of 26 tests failed). BTW, I really think we should update the unit tests in dojo core. Some unit tests in dojo/tests are still failed.

Attachments (1)

colors.patch​ (1.3 KB) - added by zhangyp 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by zhangyp

Attachment: colors.patch​ added

comment:1 Changed 8 years ago by bill

Milestone: tbd → 1.7

I'm also really saddened by the unit tests failures in core. Probably the thing to do is to track down what revision broke those tests.

comment:2 Changed 8 years ago by bill

Owner: set to bill
Resolution: → fixed
Status: new → closed

In [26101]:

Updates to DeferredList, behavior, cache, colors, currency to use granular dependencies and module return values, thanks Stephen Zhang (CLA on file), fixes #13616, #13618, #13619, #13620, #13621 !strict.

Note: See TracTickets for help on using tickets.