Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13601 closed enhancement (fixed)

[CLA][PATCH] make dojox.form.Uploader inline

Reported by: liucougar Owned by: liucougar
Priority: high Milestone: 1.7
Component: DojoX Form Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

all dijit.form widgets are inline block element: change dojox.form.Uploader to be inline block (from display=block)

Attachments (1)

13601.patch​ (13.7 KB) - added by liucougar 8 years ago.
proposed patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by liucougar

Attachment: 13601.patch​ added

proposed patch

comment:1 Changed 8 years ago by liucougar

the attached patch changes dojox.form.Uploader to inherit dijit.form.Button, which is inline-block and this simplifies the code as well

also added a new option: showInput, which mimics native file input element if it's set to 'before'

the patch also cleans up test_Uploader.html file, and added an inline button with showInput=before

comment:2 Changed 8 years ago by liucougar

Summary: make dojox.form.Uploader inline → []make dojox.form.Uploader inline

mwilcox: let me know if you see any issues with the patch

comment:3 Changed 8 years ago by liucougar

Summary: []make dojox.form.Uploader inline → [CLA][PATCH] make dojox.form.Uploader inline

comment:4 Changed 8 years ago by liucougar

Resolution: → fixed
Status: new → closed

In [26135]:

fixes #13601: make dojox.form.Uploader inherit dijit.form.Button

so it's an inline element.

updated test_Uploader.html to show how to use the inline mode and showInput option

cleanup test_Uploader.html

comment:5 Changed 8 years ago by liucougar

In [26136]:

refs #13601: forgot to commit this Uploader template in the last commit

Note: See TracTickets for help on using tickets.