Opened 8 years ago

Closed 4 years ago

#13590 closed defect (patchwelcome)

dojox.widget.Loader broken in 1.7

Reported by: William Riley Owned by: dante
Priority: high Milestone: 1.13
Component: DojoX Widgets Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The dojox.widget.Loader is broken in Dojo 1.7, likely due to changes in how dojo.Deferred works.

http://archive.dojotoolkit.org/nightly/checkout/dojox/widget/tests/test_Loader.html

The line in question (line 63 of Loader.js):

this._xhrEnd = this.connect(dojo.Deferred.prototype,"_fire","_hide");

dojo.xhr uses sub/pub during events (/dojo/io/*), so the widget could latch onto those instead of the current hack-ish method. The only problem is that for these events to be published, dojo.config.ioPublish needs to be set to true, and my impression is that the developer is supposed to be setting dojo.config, not dojo modules.

Change History (1)

comment:1 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.