Opened 8 years ago

Closed 6 years ago

#13561 closed defect (fixed)

[patch][cla] gotoPercent has no effect on animations return by dojo.fx.chain

Reported by: tomc974 Owned by: dylan
Priority: high Milestone: 1.10
Component: fx Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

I was trying the following code :

dojo.fx.chain([dojo.fadeOut({node: "nodeId"}), dojo.fadeIn({node: "nodeId"})]).gotoPercent(0.5, true) ;

Neither did the animation starts playing nor go to 50%. I tried to chain the play() method but it doesn't start the animation. When I use play() directly on the result of dojo.fx.chain() it works.

Attachments (1)

gotopercent-testcase.html​ (928 bytes) - added by Nick Nisi 6 years ago.
A test case demonstrating the bug described and demonstrating its fix

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Nick Nisi

Attachment: gotopercent-testcase.html​ added

A test case demonstrating the bug described and demonstrating its fix

comment:1 Changed 6 years ago by bill

Summary: gotoPercent has no effect on animations return by dojo.fx.chain → [patch] gotoPercent has no effect on animations return by dojo.fx.chain

Patch is in ​https://github.com/dojo/dojo/pull/22.

comment:2 Changed 6 years ago by dylan

Reviewed patch. It looks ok. Advised nicknisi to add a test, and to run and verify tests in dojo and dojox/fx to verify no regressions.

comment:3 Changed 6 years ago by dylan

Milestone: tbd → 1.10

comment:4 Changed 6 years ago by dylan

Summary: [patch] gotoPercent has no effect on animations return by dojo.fx.chain → [patch][cla] gotoPercent has no effect on animations return by dojo.fx.chain

comment:5 Changed 6 years ago by dylan

Owner: changed from Bryan Forbes to dylan
Status: new → assigned

comment:6 Changed 6 years ago by dylan

Resolution: → fixed
Status: assigned → closed

Fixed in ​https://github.com/dojo/dojo/commit/4120dba

Note: See TracTickets for help on using tickets.