Opened 8 years ago

Closed 4 years ago

#13549 closed defect (patchwelcome)

RadioGroup - no code to reorder buttons if changes made dynamically

Reported by: cindyskach Owned by: dante
Priority: high Milestone: 1.13
Component: DojoX Layout Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Adam Peller)

When making changes dynamically to the title of one of RadioGroup's content panes, if you remove it and add it back in, the button is always added to the end. Like if you have [Page1] and [Page2] and you change the title of "Page1" to "PageA" dynamically, the buttons are reordered to [Page2] and [PageA].

I believe the problem is in Radio Group's _setupChild():

var tmp = this.buttonNode.appendChild(dojo.create('td'));
            var n = dojo.create("div", null, tmp),
                _Button = dojo.getObject(this.buttonClass),
                tmpw = new _Button({
                    label: child.title,
                    page: child
                }, n)
            ;

Change History (2)

comment:1 Changed 8 years ago by Adam Peller

Description: modified (diff)
Owner: set to dante

comment:2 Changed 4 years ago by dylan

Milestone: tbd1.12
Resolution: patchwelcome
Status: newclosed

Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.