Opened 10 years ago
Closed 10 years ago
#13537 closed defect (wontfix)
'#' CSS property prefix breaks LESS
Reported by: | Sam Foster | Owned by: | nonken |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | themes | Version: | 1.6.1 |
Keywords: | Cc: | bill, kiuma | |
Blocked By: | Blocking: |
Description
In dijit.css there are a few places where we use '#' as a property-name prefix to target IE. This character hasa special meaning in this context for LESS and is tripping up its parser.
Although dijit.css is not currently LESS-ified, we should play nice with LESS wherever we can, and allow folks to lessify this and any other stylesheet as that's the tool we're endorsing.
the '*' character appears to have the same effect of filtering all but IE, and is safe for use with LESS. '_' should also work.
Attachments (1)
Change History (7)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
http://paulirish.com/2009/browser-specific-css-hacks/ is a good reference for how to target specific browsers with css. it shows that '#' and '*' target ie6 and ie7 whereas '_' only targets ie6. so, substituting '*' for '#' should work.
comment:3 follow-up: 4 Changed 10 years ago by
Hmm, I could change the # to * but I don't see what practical value this would have. Why would people run dijit.css through LESS when dijit.css doesn't have any less directives?
comment:4 Changed 10 years ago by
Replying to bill:
Hmm, I could change the # to * but I don't see what practical value this would have. Why would people run dijit.css through LESS when dijit.css doesn't have any less directives?
Ok I admit that dijit.less is not of very practical use, but for a claro.less is still an option because it gives the possibility to use less.js client side with all its advantages for testing during development.
Changed 10 years ago by
Attachment: | lessFriendlyDijitCss.patch added |
---|
patch to dijit.css, needs testing (on IE especially)
comment:6 Changed 10 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Going to close this for now. I don't see any practical reason to change dijit.css.
a less version of claro.css and dijit.css could be made to help runtime testing