Opened 8 years ago

Closed 8 years ago

#13511 closed defect (fixed)

[regression] combobox.set('store', itemfilereadstore) fails

Reported by: Douglas Hays Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit - Form Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

ComboBox:postMixInProperties tries to make old data stores compatible. But if the store is set programmatically after postMixInProperties has run then the conversion does not happen. This is preventing dojox.calc from working in Dojo 1.7. dojox.calc has a ComboBox? in a template and the store is set inside the parent startup method.

Attachments (1)

13511.patch (1.3 KB) - added by bill 8 years ago.
passes dijit regression but don't know how to test it against calc

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by bill

Hmm, how do I reproduce? I see FuncGen.js includes ComboBox but I don't actually see it being used in a template, or anywhere else i the dojox/calc code.

comment:2 Changed 8 years ago by bill

PS: I do see the template using a ComboButton, even though that isn't listed in the define()'s dependency list.

Changed 8 years ago by bill

Attachment: 13511.patch added

passes dijit regression but don't know how to test it against calc

comment:3 Changed 8 years ago by bill

Oh, I found it in the template, I had accidentally set my search to look at *.js files only. Doug updated calc to use MemoryStore so this problem doesn't occur anymore against dojox.calc. I'll check in the fix anyway.

comment:4 Changed 8 years ago by bill

Description: modified (diff)

(In [25934]) Allow dynamic update of ComboBox.store, refs #12373, fixes #13511 !strict

comment:5 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.