Opened 8 years ago

Closed 8 years ago

#13495 closed defect (fixed)

Wrong l10n information in dojo.cldr.supplemental

Reported by: ceduardo.melo Owned by: Adam Peller
Priority: high Milestone: 1.8
Component: Internationalization Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The method dojo.cldr.supplemental.getFirstDayOfWeek() returns 1 for locale 'pt-br', although here in Brazil we use Sunday as the first day of week.

Inspecting http://unicode.org/repos/cldr/trunk/common/supplemental/supplementalData.xml we see that BR region uses 'sun' as the first day of week.

I suggest a review of the information returned by this method.

Change History (6)

comment:1 Changed 8 years ago by Adam Peller

It looks like this is consistent with the CLDR repository used at the time of release

http://unicode.org/repos/cldr/tags/release-1-7/common/supplemental/supplementalData.xml

I'm not sure if we're going to get an upgrade in for Dojo 1.7, but we could just update this table...

comment:2 Changed 8 years ago by Adam Peller

For reference, the CLDR ticket can be traced from here: http://unicode.org/cldr/trac/ticket/3118 I think we're on CLDR 1.9 now

comment:3 Changed 8 years ago by André Ribeiro de Miranda

To resolve this problem by adding the following sentence below

br: 0

File: dojo/CLDR/supplemental.js
Variable: firstDay,
method: dojo.cldr.supplemental.getFirstDayOfWeek

Staying as follows

before:

	var firstDay = {/*default is 1=Monday*/
		mv:5,
		ae:6,af:6,bh:6,dj:6,dz:6,eg:6,er:6,et:6,iq:6,ir:6,jo:6,ke:6,kw:6,
		ly:6,ma:6,om:6,qa:6,sa:6,sd:6,so:6,sy:6,tn:6,ye:6,
		ar:0,as:0,az:0,bw:0,ca:0,cn:0,fo:0,ge:0,gl:0,gu:0,hk:0,
		il:0,'in':0,jm:0,jp:0,kg:0,kr:0,la:0,mh:0,mn:0,mo:0,mp:0,
		mt:0,nz:0,ph:0,pk:0,sg:0,th:0,tt:0,tw:0,um:0,us:0,uz:0,
		vi:0,zw:0
// variant. do not use?		gb:0,
	};

after:

	var firstDay = {/*default is 1=Monday*/
		mv:5,
		ae:6,af:6,bh:6,dj:6,dz:6,eg:6,er:6,et:6,iq:6,ir:6,jo:6,ke:6,kw:6,
		ly:6,ma:6,om:6,qa:6,sa:6,sd:6,so:6,sy:6,tn:6,ye:6,
		ar:0,as:0,az:0,br:0,bw:0,ca:0,cn:0,fo:0,ge:0,gl:0,gu:0,hk:0,
		il:0,'in':0,jm:0,jp:0,kg:0,kr:0,la:0,mh:0,mn:0,mo:0,mp:0,
		mt:0,nz:0,ph:0,pk:0,sg:0,th:0,tt:0,tw:0,um:0,us:0,uz:0,
		vi:0,zw:0
// variant. do not use?		gb:0,
	};

comment:4 Changed 8 years ago by Adam Peller

Milestone: tbd1.8

Try upgrading to CLDR 2.0 for Dojo 1.8

comment:5 Changed 8 years ago by Adam Peller

Status: newassigned

comment:6 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

In [28073]:

Update data to match CLDR v21.0 release. Refs #13906, Fixes #13495

Note: See TracTickets for help on using tickets.