Changes between Initial Version and Version 1 of Ticket #13488, comment 4


Ignore:
Timestamp:
Aug 18, 2011, 6:53:55 AM (9 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13488, comment 4

    initial v1  
    22
    33The issue is that:
    4   1) the close icon is inside the title bar
    5   2) the title bar is the drag handle for the Dialog
     4  1. the close icon is inside the title bar
     5  2. the title bar is the drag handle for the Dialog
    66
    77In dojo/dnd/Moveable.js, touching the [x] icon calls:
     
    2727
    2828ISTM like the dojo.stopEvent() should be replaced by e.stopPropagation(), or maybe nothing at all, but I'm not sure what Eugene had in mind for this code, or what side effects such a change would have, so assigning to him.   (Note that there are a number of dojo.stopEvent() calls in that file, maybe all of them should be changed.)
     29
     30Alternately, maybe it's not allowed to have a button inside of a drag handle?   But that seems a bit restrictive.