Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13468 closed defect (fixed)

[patch] Initialization of dojo.config.require throws error in WebKit Mobile builds

Reported by: Thomas Bachem Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: General Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Related to #13467, we have an "Uncaught TypeError?: Array.prototype.forEach called on null or undefined" on each page with the WebKit? Mobile build.

Changing dojo/_base/browser.js line 24 from

dojo.forEach(dojo.config.require, function(i){

to

dojo.forEach(dojo.config.require || [], function(i){

fixes this.

Attachments (1)

dijitForeach.patch (901 bytes) - added by Thomas Bachem 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by bill

Owner: set to Rawld Gill

comment:2 Changed 8 years ago by Thomas Bachem

Same thing in dijit/_Templated.js, find patch attached. I think there are many other places that may be problematic, so perhaps it would be better to deviate from the native behaviour of Array.forEach() and make dojo.forEach() always ignore an empty first argument, even in WebKit? Mobile builds.

Changed 8 years ago by Thomas Bachem

Attachment: dijitForeach.patch added

comment:3 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:4 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

v1.7 does not provide the option to include the native array functions as part of a webkit build--the dojo functions are included unconditionally.

Note that the native functions are much slower in some cases because they do not process sparse arrays.

comment:5 Changed 8 years ago by bill

Milestone: tbd1.7

comment:6 Changed 8 years ago by bill

For reference, the webkit special path code was removed in [24328].

Note: See TracTickets for help on using tickets.