Opened 8 years ago

Closed 8 years ago

#13417 closed enhancement (invalid)

Checking instance type should allow subclasses.

Reported by: nkzawa Owned by: ykami
Priority: high Milestone: tbd
Component: DojoX Mobile Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

On the dojox.mobile.common.js, checking if a widget is a instance of dojox.mobile.Heading is too strict. I can't make subclass of Heading because of this. Also I think that all the function of dojo.addOnload should be overridable.

line 368: dir = (w instanceof dm.Heading) ? -1 : 1;

This should be like: dir = w.isInstanceOf(dm.Heading) ? -1 : 1;

Change History (3)

comment:1 Changed 8 years ago by ykami

The instanceOf check should return true for subclasses of Heading as well. How did you create your subclass? I guess it is not recognized as a subclass of Heading.

comment:2 Changed 8 years ago by nkzawa

You were right. I didn't notice about that the instanceof keyword accepts subclasses. Maybe I just mistook something. Thank for your reply.

comment:3 Changed 8 years ago by ykami

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.