Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13405 closed defect (fixed)

dojo.store.DataStore correctly gets item by identity but don't always report their correct identity on getIdentity

Reported by: cjolif Owned by: Kris Zyp
Priority: high Milestone: 1.7
Component: DojoX Data Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When you wrap a dojo.data store in a dojo.store.DataStore you get correct result when calling: var myItem = store.get(anItemID) but if you try to get the id on the item itself: store.getIdentity(myItem) it won't give the correct ID. This happen when implicit ID is used (for example on CsvStore this is the row #, for XmlStore this is the Xpath query).

In other terms: store.get(store.get(anItemID).getIdentity()) does not work when implicit ID is used.

Attach a test case showing the problem.

Attachments (3)

DataCsvStore.js (654 bytes) - added by cjolif 8 years ago.
goog_prices.csv (42.1 KB) - added by cjolif 8 years ago.
dojo.store.DataStore.patch (1.3 KB) - added by cjolif 8 years ago.
possible patch (IBM, CCLA)

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by cjolif

Attachment: DataCsvStore.js added

Changed 8 years ago by cjolif

Attachment: goog_prices.csv added

comment:1 Changed 8 years ago by bill

Description: modified (diff)
Owner: changed from Jared Jurkiewicz to Kris Zyp

Changed 8 years ago by cjolif

Attachment: dojo.store.DataStore.patch added

possible patch (IBM, CCLA)

comment:2 Changed 8 years ago by Kris Zyp

Resolution: fixed
Status: newclosed

(In [25759]) Fix handling of data stores with implicit ids, fixes #13405 !strict

comment:3 Changed 8 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.