Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13404 closed defect (fixed)

[patch][ccla] canvas.Polyline.getBoundingBox fails if points are set as [x1,y1,x2,y2,..]

Reported by: Patrick Ruzand Owned by: Eugene Lazutkin
Priority: high Milestone: 1.7
Component: DojoX GFX Version: 1.7.0b1
Keywords: Cc: pruzand@…
Blocked By: Blocking:

Description

When using the canvas renderer, if the points of a polyline are initialized using the [x1,y1,x2,y2,...] format (as opposed to an array of points), then getBoundingBox returns an invalid value.

This happens because the Polyline.setShape() canvas implementation does not normalize the points array (that is, ensures the points are in the form "array of points"), while Polyline.getBoundingBox expects the points array to be normalized.

Attachments (2)

13404.patch (3.9 KB) - added by Patrick Ruzand 8 years ago.
Patch by Patrick Ruzand (IBM, CCLA)
13404.2.patch (3.9 KB) - added by Patrick Ruzand 8 years ago.
update to last canvas.js rev.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Patrick Ruzand

Attachment: 13404.patch added

Patch by Patrick Ruzand (IBM, CCLA)

Changed 8 years ago by Patrick Ruzand

Attachment: 13404.2.patch added

update to last canvas.js rev.

comment:1 Changed 8 years ago by Chris Mitchell

Resolution: fixed
Status: newclosed

In [26231]:

fixes #13404 canvas polyline patch. thx pruzand, IBM \!strict

comment:2 Changed 8 years ago by Chris Mitchell

In [26232]:

refs #13404 canvas polyline testcase thx pruzand, IBM \!strict

Note: See TracTickets for help on using tickets.